Merged
Conversation
Signed-off-by: Sam Gammon <sam@elide.ventures>
Signed-off-by: Sam Gammon <sam@elide.ventures>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
==========================================
+ Coverage 86.14% 86.40% +0.26%
==========================================
Files 8 13 +5
Lines 635 1236 +601
==========================================
+ Hits 547 1068 +521
- Misses 88 168 +80
|
There was a problem hiding this comment.
Pull request overview
Adds a new installer input to control how Elide is installed in this GitHub Action, while refactoring option parsing and splitting install flows into dedicated modules.
Changes:
- Introduces
installer(archive/shell/msi/pkg/apt/rpm) and routes installation accordingly. - Refactors option parsing into
buildOptionsFromInputsand expands option normalization/validation helpers. - Adds new installer implementations (shell/msi/pkg/rpm), updates CDN URL construction, and refreshes tests/scripts.
Reviewed changes
Copilot reviewed 25 out of 27 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/releases.ts | Refactors CDN URL generation (adds buildCdnAssetUrl) and updates download URL building. |
| src/platform.ts | Adds RPM-based distro detection helper. |
| src/outputs.ts | Removes separate outputs model (outputs now defined elsewhere). |
| src/options.ts | Adds installer/no-cache options, input parsing via @actions/core, and installer validation. |
| src/main.ts | Routes install flow based on installer, refactors outputs, replaces prewarm/info with post-install elideInfo. |
| src/install-shell.ts | New shell-script based installer (bash/PowerShell). |
| src/install-script.ts | Removes old script installer implementation (replaced by install-shell). |
| src/install-msi.ts | New Windows MSI installer implementation. |
| src/install-pkg.ts | New macOS PKG installer implementation. |
| src/install-rpm.ts | New RPM installer implementation (dnf/rpm). |
| src/config.ts | Removes GitHub API header constants (moved into releases module). |
| src/command.ts | Removes prewarm and renames info to elideInfo. |
| package.json | Updates test script list and docker test command. |
| action.yml | Adds installer, no_cache, version_tag inputs and version output; fixes boolean defaults to strings. |
| tests/releases.test.ts | Adds coverage for buildCdnAssetUrl; updates URL expectations with ?source=gha. |
| tests/releases-download.test.ts | Updates command mocks; removes alpha7/alpha8 special-case test. |
| tests/platform.test.ts | Adds tests for isRpmBased. |
| tests/options.test.ts | Adds tests for installer normalization/validation and default installer. |
| tests/main.test.ts | Updates mocks/imports and adds installer routing + fallback behavior tests. |
| tests/install-shell.test.ts | New tests for shell installer behavior. |
| tests/install-msi.test.ts | New tests for MSI installer behavior. |
| tests/install-pkg.test.ts | Updates to test PKG installer behavior. |
| tests/install-rpm.test.ts | New tests for RPM installer behavior. |
| tests/install-apt.test.ts | Updates command mocks to elideInfo. |
| tests/command.test.ts | Updates tests for elideInfo and removes prewarm/info cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Sam Gammon <sam@elide.ventures>
Signed-off-by: Sam Gammon <sam@elide.ventures>
Signed-off-by: Sam Gammon <sam@elide.ventures>
Signed-off-by: Sam Gammon <sam@elide.ventures>
Signed-off-by: Sam Gammon <sam@elide.ventures>
Signed-off-by: Sam Gammon <sam@elide.ventures>
Signed-off-by: Sam Gammon <sam@elide.ventures>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an input which controls what kind of installation takes place; performs cleanup and general refactoring